Allow editing orders in the order card
Cashiers can edit recipient, TTN, notes, goods and total in the order
modal and save via PATCH /orders/{id}. Edited orders get edited_at and
are no longer overwritten by CRM sync. Editing is blocked once a receipt
exists; changing the TTN resets Nova Poshta tracking fields.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,26 @@
|
||||
"""Отметка о ручном редактировании заказа
|
||||
|
||||
Revision ID: 0007
|
||||
Revises: 0006
|
||||
Create Date: 2026-09-24
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from collections.abc import Sequence
|
||||
|
||||
import sqlalchemy as sa
|
||||
from alembic import op
|
||||
|
||||
revision: str = "0007"
|
||||
down_revision: str | None = "0006"
|
||||
branch_labels: str | Sequence[str] | None = None
|
||||
depends_on: str | Sequence[str] | None = None
|
||||
|
||||
|
||||
def upgrade() -> None:
|
||||
op.add_column("orders", sa.Column("edited_at", sa.DateTime(timezone=True), nullable=True))
|
||||
|
||||
|
||||
def downgrade() -> None:
|
||||
op.drop_column("orders", "edited_at")
|
||||
@@ -1,4 +1,4 @@
|
||||
"""Локальная очередь заказов (синхронизируется из CRM) — список, вкладки, удаление."""
|
||||
"""Локальная очередь заказов (синхронизируется из CRM) — список, вкладки, правка, удаление."""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
@@ -6,7 +6,7 @@ from fastapi import APIRouter, Depends, HTTPException, Request, status
|
||||
|
||||
from app.api.deps import CashierUser, CrmClientDep, SessionDep, require_any
|
||||
from app.db.models.audit import AuditAction
|
||||
from app.schemas.orders import OrderRowOut
|
||||
from app.schemas.orders import OrderRowOut, OrderUpdateIn
|
||||
from app.services import audit
|
||||
from app.services import orders as orders_service
|
||||
from app.services import receipts as receipts_service
|
||||
@@ -28,6 +28,38 @@ async def list_orders(
|
||||
return [OrderRowOut.from_order(order, receipts.get(order.id)) for order in orders]
|
||||
|
||||
|
||||
@router.patch("/{order_id}", response_model=OrderRowOut, response_model_by_alias=False)
|
||||
async def update_order(
|
||||
order_id: str,
|
||||
payload: OrderUpdateIn,
|
||||
request: Request,
|
||||
session: SessionDep,
|
||||
actor: CashierUser,
|
||||
) -> OrderRowOut:
|
||||
try:
|
||||
result = await orders_service.update_order(session, order_id, payload)
|
||||
except orders_service.OrderEditError as exc:
|
||||
raise HTTPException(status_code=status.HTTP_409_CONFLICT, detail=str(exc)) from exc
|
||||
if result is None:
|
||||
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Заказ не найден")
|
||||
|
||||
order, changed = result
|
||||
if changed:
|
||||
await audit.record(
|
||||
session,
|
||||
action=AuditAction.ORDER_UPDATED,
|
||||
user=actor,
|
||||
entity_type="order",
|
||||
entity_id=order.id,
|
||||
payload={"fields": changed},
|
||||
request=request,
|
||||
)
|
||||
await session.commit()
|
||||
|
||||
receipts = await receipts_service.latest_receipts_by_order(session, [order.id])
|
||||
return OrderRowOut.from_order(order, receipts.get(order.id))
|
||||
|
||||
|
||||
@router.delete("/{order_id}", status_code=status.HTTP_204_NO_CONTENT)
|
||||
async def delete_order(
|
||||
order_id: str, request: Request, session: SessionDep, actor: CashierUser
|
||||
|
||||
@@ -32,6 +32,7 @@ class AuditAction(str):
|
||||
USER_UPDATED = "user.updated"
|
||||
USER_DEACTIVATED = "user.deactivated"
|
||||
ORDER_DELETED = "order.deleted"
|
||||
ORDER_UPDATED = "order.updated"
|
||||
CASH_REGISTER_CREATED = "cash_register.created"
|
||||
CASH_REGISTER_UPDATED = "cash_register.updated"
|
||||
RECEIPT_CREATE_REQUESTED = "receipt.create_requested"
|
||||
|
||||
@@ -41,6 +41,10 @@ class Order(TimestampMixin, Base):
|
||||
is_deleted: Mapped[bool] = mapped_column(Boolean, nullable=False, default=False, index=True)
|
||||
deleted_at: Mapped[datetime | None] = mapped_column(DateTime(timezone=True))
|
||||
|
||||
# Заказ правили вручную в карточке — синхронизация из CRM его больше не
|
||||
# перезаписывает, иначе правки кассира затирались бы при следующем открытии.
|
||||
edited_at: Mapped[datetime | None] = mapped_column(DateTime(timezone=True))
|
||||
|
||||
# Заполняется будущей интеграцией с Checkbox — сейчас всегда NULL.
|
||||
receipt_created_at: Mapped[datetime | None] = mapped_column(DateTime(timezone=True), index=True)
|
||||
|
||||
|
||||
@@ -10,6 +10,7 @@ integer-kopecks из CLAUDE.md относится к будущим персис
|
||||
from __future__ import annotations
|
||||
|
||||
from datetime import datetime
|
||||
from decimal import Decimal
|
||||
from typing import TYPE_CHECKING, Any
|
||||
|
||||
from pydantic import BaseModel, ConfigDict, Field, field_validator
|
||||
@@ -88,6 +89,7 @@ class OrderRowOut(BaseModel):
|
||||
receipt_status: str | None = None
|
||||
receipt_error: str | None = None
|
||||
receipt_prepayment: str | None = None
|
||||
edited: bool = False
|
||||
|
||||
@classmethod
|
||||
def from_order(cls, order: Order, receipt: Receipt | None = None) -> OrderRowOut:
|
||||
@@ -116,4 +118,43 @@ class OrderRowOut(BaseModel):
|
||||
receipt_prepayment=(
|
||||
f"{receipt.prepayment_kopecks / 100:.2f}" if receipt else None
|
||||
),
|
||||
edited=order.edited_at is not None,
|
||||
)
|
||||
|
||||
|
||||
class OrderGoodIn(BaseModel):
|
||||
"""Позиция заказа из формы редактирования. `amount` считает сервер."""
|
||||
|
||||
id: str | None = Field(default=None, max_length=64)
|
||||
sku: str = Field(default="", max_length=128)
|
||||
name: str = Field(min_length=1, max_length=512)
|
||||
price: Decimal = Field(ge=0, max_digits=12, decimal_places=2)
|
||||
quantity: Decimal = Field(gt=0, max_digits=12, decimal_places=3)
|
||||
discount_amount: Decimal = Field(default=Decimal(0), ge=0, max_digits=12, decimal_places=2)
|
||||
|
||||
@field_validator("sku", "name", mode="after")
|
||||
@classmethod
|
||||
def _strip(cls, value: str) -> str:
|
||||
return value.strip()
|
||||
|
||||
|
||||
class OrderUpdateIn(BaseModel):
|
||||
"""`PATCH /orders/{id}` — полная замена редактируемых полей заказа."""
|
||||
|
||||
recipient_name: str | None = Field(default=None, max_length=255)
|
||||
recipient_phone: str | None = Field(default=None, max_length=32)
|
||||
recipient_email: str | None = Field(default=None, max_length=320)
|
||||
waybill_number: str | None = Field(default=None, max_length=64)
|
||||
notes: str | None = None
|
||||
total_amount: Decimal = Field(ge=0, max_digits=12, decimal_places=2)
|
||||
goods: list[OrderGoodIn] = Field(min_length=1)
|
||||
|
||||
# Пустая строка из формы = «не указано».
|
||||
@field_validator(
|
||||
"recipient_name", "recipient_phone", "recipient_email", "waybill_number", "notes"
|
||||
)
|
||||
@classmethod
|
||||
def _blank_to_none(cls, value: str | None) -> str | None:
|
||||
if value is None:
|
||||
return None
|
||||
return value.strip() or None
|
||||
|
||||
@@ -2,13 +2,16 @@
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import uuid
|
||||
from datetime import UTC, datetime
|
||||
from decimal import Decimal
|
||||
from decimal import ROUND_HALF_UP, Decimal
|
||||
from typing import Any
|
||||
|
||||
from sqlalchemy import select
|
||||
from sqlalchemy.ext.asyncio import AsyncSession
|
||||
|
||||
from app.db.models.order import Order
|
||||
from app.schemas.orders import OrderUpdateIn
|
||||
from app.services.crm.client import CrmClient
|
||||
from app.services.nova_poshta.client import NovaPoshtaClient
|
||||
|
||||
@@ -17,6 +20,19 @@ _CRM_STATUS = "APPROVED"
|
||||
# NP отклоняет запросы с более чем 100 накладными за раз (см. np_client.py).
|
||||
_NP_BATCH_SIZE = 100
|
||||
|
||||
# Поля, которые кассир может править в карточке заказа (кроме goods/total).
|
||||
_EDITABLE_FIELDS = (
|
||||
"recipient_name",
|
||||
"recipient_phone",
|
||||
"recipient_email",
|
||||
"waybill_number",
|
||||
"notes",
|
||||
)
|
||||
|
||||
|
||||
class OrderEditError(Exception):
|
||||
"""Заказ нельзя сохранить — сообщение показывается кассиру."""
|
||||
|
||||
|
||||
def _to_kopecks(amount: str) -> int:
|
||||
return int((Decimal(amount) * 100).to_integral_value())
|
||||
@@ -31,7 +47,8 @@ async def sync_orders_from_crm(session: AsyncSession, crm: CrmClient) -> None:
|
||||
|
||||
Уже скрытые (`is_deleted`) заказы не восстанавливаются и не перезаписываются
|
||||
— иначе кнопка «Удалить» переставала бы работать при следующем открытии
|
||||
дашборда, т.к. CRM продолжает возвращать эти заказы как есть.
|
||||
дашборда, т.к. CRM продолжает возвращать эти заказы как есть. По той же
|
||||
причине не трогаются заказы, отредактированные вручную (`edited_at`).
|
||||
"""
|
||||
crm_orders = await crm.get_orders(status=_CRM_STATUS)
|
||||
if not crm_orders:
|
||||
@@ -45,7 +62,7 @@ async def sync_orders_from_crm(session: AsyncSession, crm: CrmClient) -> None:
|
||||
for crm_order in crm_orders:
|
||||
local = existing_by_id.get(crm_order.id)
|
||||
if local is not None:
|
||||
if local.is_deleted:
|
||||
if local.is_deleted or local.edited_at is not None:
|
||||
continue
|
||||
else:
|
||||
local = Order(id=crm_order.id)
|
||||
@@ -119,3 +136,92 @@ async def delete_order(session: AsyncSession, order_id: str) -> Order | None:
|
||||
order.is_deleted = True
|
||||
order.deleted_at = datetime.now(UTC)
|
||||
return order
|
||||
|
||||
|
||||
def _good_key(good: dict[str, Any]) -> tuple[Any, ...]:
|
||||
"""Позиция без учёта формата строк: CRM пишет "1", форма — "1.000"."""
|
||||
return (
|
||||
good["id"],
|
||||
good.get("sku") or "",
|
||||
good["name"],
|
||||
_to_kopecks(good["price"]),
|
||||
Decimal(good["quantity"]),
|
||||
_to_kopecks(good["amount"]) if good.get("amount") else None,
|
||||
)
|
||||
|
||||
|
||||
def _build_goods(data: OrderUpdateIn) -> tuple[list[dict[str, Any]], int]:
|
||||
"""Позиции формы → снимок `orders.goods` в формате CRM и их сумма в копейках."""
|
||||
goods: list[dict[str, Any]] = []
|
||||
total = 0
|
||||
for good in data.goods:
|
||||
price = int(good.price * 100)
|
||||
discount = int(good.discount_amount * 100)
|
||||
gross = int((price * good.quantity).to_integral_value(ROUND_HALF_UP))
|
||||
net = gross - discount
|
||||
if net < 0:
|
||||
raise OrderEditError(f"Товар «{good.name}»: скидка больше суммы строки")
|
||||
goods.append(
|
||||
{
|
||||
"id": good.id or f"new-{uuid.uuid4().hex[:8]}",
|
||||
"sku": good.sku,
|
||||
"name": good.name,
|
||||
"price": f"{good.price:.2f}",
|
||||
"quantity": f"{good.quantity:.3f}",
|
||||
"discount_amount": f"{good.discount_amount:.2f}",
|
||||
"discount_percent": None,
|
||||
"amount": f"{net / 100:.2f}",
|
||||
}
|
||||
)
|
||||
total += net
|
||||
return goods, total
|
||||
|
||||
|
||||
async def update_order(
|
||||
session: AsyncSession, order_id: str, data: OrderUpdateIn
|
||||
) -> tuple[Order, list[str]] | None:
|
||||
"""Сохраняет ручные правки заказа. Возвращает заказ и список изменённых полей.
|
||||
|
||||
Править можно только заказ без чека: у заказа с чеком (в т.ч. `pending`)
|
||||
данные уже ушли или уходят в Checkbox. Строка блокируется, чтобы
|
||||
параллельный запрос на создание чека не прочитал заказ посреди правки.
|
||||
"""
|
||||
order = await session.scalar(select(Order).where(Order.id == order_id).with_for_update())
|
||||
if order is None or order.is_deleted:
|
||||
return None
|
||||
if order.receipt_created_at is not None:
|
||||
raise OrderEditError("По заказу уже создан чек — редактирование недоступно")
|
||||
|
||||
goods, goods_total = _build_goods(data)
|
||||
total = _to_kopecks(str(data.total_amount))
|
||||
if total > goods_total:
|
||||
raise OrderEditError(
|
||||
f"Сумма заказа {total / 100:.2f} ₴ больше суммы товаров {goods_total / 100:.2f} ₴"
|
||||
)
|
||||
|
||||
changed = [
|
||||
field for field in _EDITABLE_FIELDS if getattr(order, field) != getattr(data, field)
|
||||
]
|
||||
goods_changed = [_good_key(good) for good in order.goods] != [_good_key(good) for good in goods]
|
||||
if goods_changed:
|
||||
changed.append("goods")
|
||||
if order.total_amount_kopecks != total:
|
||||
changed.append("total_amount")
|
||||
if not changed:
|
||||
return order, changed
|
||||
|
||||
if "waybill_number" in changed:
|
||||
# Статус старой ТТН к новой не относится — worker опросит новую за минуту.
|
||||
order.np_status = None
|
||||
order.np_status_code = None
|
||||
order.np_cod_amount_kopecks = None
|
||||
order.np_payment_status = None
|
||||
|
||||
for field in _EDITABLE_FIELDS:
|
||||
setattr(order, field, getattr(data, field))
|
||||
if goods_changed:
|
||||
# Иначе оставляем снимок CRM как есть — форматы строк у CRM свои ("1" vs "1.000").
|
||||
order.goods = goods
|
||||
order.total_amount_kopecks = total
|
||||
order.edited_at = datetime.now(UTC)
|
||||
return order, changed
|
||||
|
||||
@@ -24,14 +24,18 @@ MODEL_TABLES = set(Base.metadata.tables)
|
||||
|
||||
|
||||
def _migration_block(table: str) -> str:
|
||||
"""Тело вызова op.create_table для указанной таблицы.
|
||||
"""Тело вызова op.create_table для указанной таблицы плюс её поздние op.add_column.
|
||||
|
||||
Границей служит следующий op.create_table; для последней таблицы — конец файла.
|
||||
Границей create_table служит следующий op.create_table или конец файла миграции.
|
||||
"""
|
||||
start = COMBINED_SOURCE.index(f'op.create_table(\n "{table}",')
|
||||
next_table = COMBINED_SOURCE.find("op.create_table(", start + 1)
|
||||
end = next_table if next_table != -1 else len(COMBINED_SOURCE)
|
||||
return COMBINED_SOURCE[start:end]
|
||||
marker = f'op.create_table(\n "{table}",'
|
||||
source = next(text for text in SOURCES.values() if marker in text)
|
||||
start = source.index(marker)
|
||||
next_table = source.find("op.create_table(", start + 1)
|
||||
end = next_table if next_table != -1 else len(source)
|
||||
# Колонки, добавленные позже через op.add_column, — в любой миграции.
|
||||
added = re.findall(rf'op\.add_column\(\s*"{table}",\s*(sa\.Column\(.*?\n)', COMBINED_SOURCE)
|
||||
return source[start:end] + "\n" + "\n".join(added)
|
||||
|
||||
|
||||
def test_migrations_create_every_model_table() -> None:
|
||||
|
||||
@@ -79,6 +79,19 @@ def _patch_orders_service(monkeypatch: pytest.MonkeyPatch) -> None:
|
||||
monkeypatch.setattr(orders_router.orders_service, "list_orders", fake_list)
|
||||
monkeypatch.setattr(orders_router.orders_service, "delete_order", fake_delete)
|
||||
|
||||
async def fake_update(
|
||||
session: object, order_id: str, data: object
|
||||
) -> tuple[Order, list[str]] | None:
|
||||
if order_id == "locked":
|
||||
raise orders_router.orders_service.OrderEditError("По заказу уже создан чек")
|
||||
if order_id != "1":
|
||||
return None
|
||||
order = _order(order_id)
|
||||
order.edited_at = datetime(2026, 9, 24, tzinfo=UTC)
|
||||
return order, ["notes"]
|
||||
|
||||
monkeypatch.setattr(orders_router.orders_service, "update_order", fake_update)
|
||||
|
||||
async def fake_latest(session: object, order_ids: list[str]) -> dict:
|
||||
return {}
|
||||
|
||||
@@ -164,3 +177,56 @@ class TestDeleteOrder:
|
||||
response = client.delete("/api/v1/orders/does-not-exist")
|
||||
|
||||
assert response.status_code == 404
|
||||
|
||||
|
||||
_UPDATE_BODY = {
|
||||
"recipient_name": "Тест Тестов",
|
||||
"recipient_phone": "+380501112233",
|
||||
"waybill_number": "20450123456789",
|
||||
"notes": "правка",
|
||||
"total_amount": "1200.00",
|
||||
"goods": [
|
||||
{"id": "1", "sku": "SKU-1", "name": "Товар 1", "price": "1200.00", "quantity": "1"}
|
||||
],
|
||||
}
|
||||
|
||||
|
||||
class TestUpdateOrder:
|
||||
@pytest.mark.parametrize("role", [UserRole.ADMIN, UserRole.CASHIER])
|
||||
def test_admin_and_cashier_can_update(self, client: TestClient, role: UserRole) -> None:
|
||||
app.dependency_overrides[get_current_user] = lambda: _user(role)
|
||||
|
||||
response = client.patch("/api/v1/orders/1", json=_UPDATE_BODY)
|
||||
|
||||
assert response.status_code == 200
|
||||
body = response.json()
|
||||
assert body["edited"] is True
|
||||
assert body["goods"][0]["sku"] == "SKU-1"
|
||||
|
||||
def test_viewer_cannot_update(self, client: TestClient) -> None:
|
||||
app.dependency_overrides[get_current_user] = lambda: _user(UserRole.VIEWER)
|
||||
|
||||
response = client.patch("/api/v1/orders/1", json=_UPDATE_BODY)
|
||||
|
||||
assert response.status_code == 403
|
||||
|
||||
def test_unknown_order_is_404(self, client: TestClient) -> None:
|
||||
app.dependency_overrides[get_current_user] = lambda: _user(UserRole.CASHIER)
|
||||
|
||||
response = client.patch("/api/v1/orders/nope", json=_UPDATE_BODY)
|
||||
|
||||
assert response.status_code == 404
|
||||
|
||||
def test_order_with_receipt_is_409(self, client: TestClient) -> None:
|
||||
app.dependency_overrides[get_current_user] = lambda: _user(UserRole.CASHIER)
|
||||
|
||||
response = client.patch("/api/v1/orders/locked", json=_UPDATE_BODY)
|
||||
|
||||
assert response.status_code == 409
|
||||
|
||||
def test_empty_goods_is_rejected(self, client: TestClient) -> None:
|
||||
app.dependency_overrides[get_current_user] = lambda: _user(UserRole.CASHIER)
|
||||
|
||||
response = client.patch("/api/v1/orders/1", json={**_UPDATE_BODY, "goods": []})
|
||||
|
||||
assert response.status_code == 422
|
||||
|
||||
@@ -1,10 +1,16 @@
|
||||
"""Юнит-тесты чистых хелперов сервиса заказов. Без БД и без сети."""
|
||||
"""Юнит-тесты сервиса заказов. Без БД и без сети — сессия подменяется заглушкой."""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from datetime import datetime
|
||||
import asyncio
|
||||
from datetime import UTC, datetime
|
||||
from typing import Any
|
||||
|
||||
from app.services.orders import _parse_crm_datetime, _to_kopecks
|
||||
import pytest
|
||||
|
||||
from app.db.models.order import Order
|
||||
from app.schemas.orders import OrderUpdateIn
|
||||
from app.services.orders import OrderEditError, _parse_crm_datetime, _to_kopecks, update_order
|
||||
|
||||
|
||||
class TestToKopecks:
|
||||
@@ -24,3 +30,121 @@ class TestToKopecks:
|
||||
class TestParseCrmDatetime:
|
||||
def test_parses_crm_format(self) -> None:
|
||||
assert _parse_crm_datetime("2026-09-20 10:00:00") == datetime(2026, 9, 20, 10, 0, 0)
|
||||
|
||||
|
||||
class _FakeSession:
|
||||
def __init__(self, order: Order | None) -> None:
|
||||
self.order = order
|
||||
|
||||
async def scalar(self, query: Any) -> Order | None:
|
||||
return self.order
|
||||
|
||||
|
||||
def _order(**overrides: Any) -> Order:
|
||||
fields: dict[str, Any] = {
|
||||
"id": "1",
|
||||
"recipient_name": "Тест",
|
||||
"recipient_phone": "0501112233",
|
||||
"recipient_email": None,
|
||||
"waybill_number": "20450000000001",
|
||||
"notes": None,
|
||||
"total_amount_kopecks": 120000,
|
||||
"goods": [],
|
||||
"is_deleted": False,
|
||||
"receipt_created_at": None,
|
||||
"edited_at": None,
|
||||
"np_status": "Прибув",
|
||||
"np_status_code": "7",
|
||||
"np_cod_amount_kopecks": 120000,
|
||||
"np_payment_status": "NeedPayment",
|
||||
}
|
||||
fields.update(overrides)
|
||||
return Order(**fields)
|
||||
|
||||
|
||||
_GOOD = {
|
||||
"id": "1",
|
||||
"sku": "A",
|
||||
"name": "Товар",
|
||||
"price": "600.00",
|
||||
"quantity": "2",
|
||||
"discount_amount": "50.00",
|
||||
}
|
||||
|
||||
|
||||
def _payload(**overrides: Any) -> OrderUpdateIn:
|
||||
data: dict[str, Any] = {
|
||||
"recipient_name": "Тест",
|
||||
"recipient_phone": "0501112233",
|
||||
"recipient_email": "",
|
||||
"waybill_number": "20450000000001",
|
||||
"notes": "",
|
||||
"total_amount": "1100.00",
|
||||
"goods": [_GOOD],
|
||||
}
|
||||
data.update(overrides)
|
||||
return OrderUpdateIn.model_validate(data)
|
||||
|
||||
|
||||
def _update(order: Order | None, payload: OrderUpdateIn) -> tuple[Order, list[str]]:
|
||||
result = asyncio.run(update_order(_FakeSession(order), "1", payload)) # type: ignore[arg-type]
|
||||
assert result is not None
|
||||
return result
|
||||
|
||||
|
||||
class TestUpdateOrder:
|
||||
def test_recomputes_line_amount_and_marks_edited(self) -> None:
|
||||
order, changed = _update(_order(), _payload())
|
||||
|
||||
assert order.goods[0]["amount"] == "1150.00"
|
||||
assert order.goods[0]["quantity"] == "2.000"
|
||||
assert order.total_amount_kopecks == 110000
|
||||
assert order.edited_at is not None
|
||||
assert set(changed) == {"goods", "total_amount"}
|
||||
|
||||
def test_blank_strings_become_null(self) -> None:
|
||||
order, _ = _update(_order(), _payload(notes=" "))
|
||||
|
||||
assert order.notes is None
|
||||
assert order.recipient_email is None
|
||||
|
||||
def test_new_line_gets_generated_id(self) -> None:
|
||||
good = {"sku": "", "name": "Новый", "price": "10.00", "quantity": "1"}
|
||||
order, _ = _update(_order(), _payload(goods=[good], total_amount="10.00"))
|
||||
|
||||
assert order.goods[0]["id"].startswith("new-")
|
||||
|
||||
def test_waybill_change_resets_np_tracking(self) -> None:
|
||||
order, changed = _update(_order(), _payload(waybill_number="20450000000002"))
|
||||
|
||||
assert "waybill_number" in changed
|
||||
assert order.np_status is None
|
||||
assert order.np_cod_amount_kopecks is None
|
||||
|
||||
def test_no_changes_does_not_mark_edited(self) -> None:
|
||||
# Снимок в формате CRM ("2", а не "2.000") — формат строк не считается правкой.
|
||||
stored = {**_GOOD, "discount_percent": "4.17", "amount": "1150.00"}
|
||||
order, changed = _update(_order(goods=[stored], total_amount_kopecks=110000), _payload())
|
||||
|
||||
assert changed == []
|
||||
assert order.edited_at is None
|
||||
assert order.goods == [stored]
|
||||
|
||||
def test_total_above_goods_sum_is_rejected(self) -> None:
|
||||
with pytest.raises(OrderEditError, match="больше суммы товаров"):
|
||||
_update(_order(), _payload(total_amount="1200.00"))
|
||||
|
||||
def test_discount_above_line_sum_is_rejected(self) -> None:
|
||||
good = {"name": "Товар", "price": "10.00", "quantity": "1", "discount_amount": "11"}
|
||||
with pytest.raises(OrderEditError, match="скидка больше"):
|
||||
_update(_order(), _payload(goods=[good], total_amount="0"))
|
||||
|
||||
def test_order_with_receipt_is_locked(self) -> None:
|
||||
with pytest.raises(OrderEditError, match="уже создан чек"):
|
||||
_update(_order(receipt_created_at=datetime.now(UTC)), _payload())
|
||||
|
||||
def test_missing_or_deleted_order_returns_none(self) -> None:
|
||||
payload = _payload()
|
||||
assert asyncio.run(update_order(_FakeSession(None), "1", payload)) is None # type: ignore[arg-type]
|
||||
deleted = _FakeSession(_order(is_deleted=True))
|
||||
assert asyncio.run(update_order(deleted, "1", payload)) is None # type: ignore[arg-type]
|
||||
|
||||
Reference in New Issue
Block a user